Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PostgreSQL testCaseSensitiveDataMapping skipping #7032

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Simplify PostgreSQL testCaseSensitiveDataMapping skipping #7032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions ...rino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import io.trino.testing.sql.JdbcSqlExecutor;
import io.trino.testing.sql.TestTable;
import org.intellij.lang.annotations.Language;
import org.testng.SkipException;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

Expand All @@ -42,7 +43,6 @@
import static java.util.stream.Collectors.joining;
import static java.util.stream.IntStream.range;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertTrue;
Expand Down Expand Up @@ -731,14 +731,8 @@ public void testTimestampColumnAndTimestampWithTimeZoneConstant()
@Override
public void testCaseSensitiveDataMapping(DataMappingTestSetup dataMappingTestSetup)
{
try {
super.testCaseSensitiveDataMapping(dataMappingTestSetup);
}
catch (AssertionError ignored) {
// TODO https://github.com/trinodb/trino/issues/3645 - PostgreSQL has different collation than Trino
assertThatThrownBy(() -> super.testCaseSensitiveDataMapping(dataMappingTestSetup))
.hasStackTraceContaining("not equal\nActual rows");
}
// TODO - https://github.com/trinodb/trino/issues/3645
throw new SkipException("PostgreSQL has different collation than Trino");
}

private String getLongInClause(int start, int length)
Expand Down