Check if Presto is not running before erasing RPM #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copy of prestodb/presto#11128 |
kokosing
changed the title
kokosing
commented
Jan 25, 2019
| @@ -83,6 +83,7 @@ | |||
| <architecture>x86_64</architecture> | |||
There was a problem hiding this comment.
update commit message to:
Check if Presto is not running before erasing RPM
martint
approved these changes
Jan 25, 2019
electrum
reviewed
Jan 27, 2019
| @@ -0,0 +1,6 @@ | |||
| # Pre erase script | |||
|
|
|||
| if ! /etc/init.d/presto status | grep -q 'Not running'; then | |||
There was a problem hiding this comment.
Do we need to grep for a message? Per the LSB standard, can we simply check for status 3?
http://refspecs.linuxbase.org/LSB_3.0.0/LSB-PDA/LSB-PDA/iniscrptact.html
There was a problem hiding this comment.
I check for non zero. In case of such status (see exit status of 1, 2)it would be nice to give a user a chance to cleanup.
According to: http://refspecs.linuxbase.org/LSB_3.0.0/LSB-PDA/LSB-PDA/iniscrptact.html when service is correctly stopped it returns 3.
kokosing
force-pushed
the
origin/master/062_rpm
branch
from
5892cbc to
d13fbf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if Presto is running before erasing RPM