Add Cassandra unit test class against latest 3.11.9 #5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to split the changes in a way so that git blame is preserved? |
adamjshook
force-pushed
the
cassandra-latest
branch
2 times, most recently
from
cc3d2dd to
69b53bb
Compare
ebyhr
reviewed
Nov 27, 2020
...o-cassandra/src/test/java/io/prestosql/plugin/cassandra/BaseCassandraDistributedQueries.java
Show resolved
Hide resolved
presto-cassandra/src/test/java/io/prestosql/plugin/cassandra/CassandraServer.java
Outdated
Show resolved
Hide resolved
This removes test coverage but it is restored in the next commit. We want to retain the history on the file changes.
adamjshook
force-pushed
the
cassandra-latest
branch
from
69b53bb to
09741f1
Compare
ebyhr
approved these changes
Nov 30, 2020
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #5804
This commit refactors the distributed query tests into a base with two implementations, the existing unit tests against the 2.2.x version of Cassandra and a new test class against the latest 3.11.9 version.