-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
information_schema should not fail for illegal storage format #568
Conversation
7736f10
to
fef6c3b
Compare
fef6c3b
to
4beaddb
Compare
It is not possible to create this through Presto. You would need to use the metastore API directly or possibly use Hive (could be done with a product test).
|
See io.prestosql.tests.utils.QueryExecutors#onHive, with this you can pass SQL to hive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Please fix the build failure, then I can merge it. Thanks for fixing this issue.
@@ -108,6 +108,7 @@ | |||
import org.apache.hadoop.fs.FileSystem; | |||
import org.apache.hadoop.fs.Path; | |||
import org.apache.hadoop.hive.metastore.TableType; | |||
import org.iq80.leveldb.table.TableBuilder; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was accidentally imported and is causing the build to fail. Please remove it.
@VicoWu Do you want to fix the build failure? Otherwise I can fix it up and merge it |
@electrum The build error has been fixed. Thanks |
Thanks! Can you squash the commits? |
Merged, thanks! |
Hi @electrum @kokosing
I have just migrated the original PR(prestodb/presto#11847) from prestodb to prestosql.