Remove unused HiveViewNotSupportedException class #5599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
commented
Oct 19, 2020
|
|
||
| import static java.lang.String.format; | ||
|
|
||
| public class HiveViewNotSupportedException |
There was a problem hiding this comment.
This means we do not have a kill-switch for Coral support.
Is it intentional?
@electrum @laurachenyu @kokosing or @martint do you happen to know?
There was a problem hiding this comment.
I intentionally remove HiveViewNotSupportedException in:
presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHive.java
presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/thrift/ThriftHiveMetastore.java
Because these tests are no longer needed with coral integration #4661.
There was a problem hiding this comment.
we do not have a kill-switch for Coral support.
What about hive.translate-hive-views?
The `HiveViewNotSupportedException` is never thrown anymore. Usage got removed in 47dbba4
findepi
force-pushed
the
findepi/unused
branch
from
5455811 to
a0c1ca1
Compare
findepi
changed the title
|
Superseded by #5636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage got removed in 47dbba4