Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for lazy dynamic filters for replicated joins #4685

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Support for lazy dynamic filters for replicated joins #4685

merged 2 commits into from
Sep 15, 2020

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Aug 4, 2020 •
edited
Loading

Depends on: #4675

@sopel39 sopel39 added the WIP label Aug 4, 2020
@cla-bot cla-bot bot added the cla-signed label Aug 4, 2020
@sopel39 sopel39 force-pushed the ks/df_broadcast_joins branch from 7a9dbdf to c423834 Compare August 5, 2020 13:34
@sopel39 sopel39 changed the title Support for lazy replicated joins Support for lazy dynamic filters for replicated joins Aug 5, 2020
@sopel39 sopel39 force-pushed the ks/df_broadcast_joins branch from c423834 to fa9604f Compare August 18, 2020 12:20
@sopel39 sopel39 removed the WIP label Aug 18, 2020
@sopel39 sopel39 force-pushed the ks/df_broadcast_joins branch 6 times, most recently from 84978a1 to 5c35bce Compare August 20, 2020 14:08
@sopel39 sopel39 requested a review from dain August 21, 2020 19:55
@sopel39 sopel39 force-pushed the ks/df_broadcast_joins branch from 5c35bce to 22c4c29 Compare September 1, 2020 13:08
@sopel39
Copy link
Member Author

sopel39 commented Sep 1, 2020

I've removed usage of EmptySplit in favor of creating a task explicitly on random node.

@sopel39 sopel39 force-pushed the ks/df_broadcast_joins branch from 22c4c29 to c5ad9f8 Compare September 14, 2020 14:18
@sopel39
Copy link
Member Author

sopel39 commented Sep 14, 2020

rebased @dain @martint

dain
dain approved these changes Sep 14, 2020
View reviewed changes
presto-main/src/main/java/io/prestosql/execution/scheduler/SourcePartitionedScheduler.java Outdated Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/execution/scheduler/SourcePartitionedScheduler.java Outdated Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/server/DynamicFilterService.java Outdated Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/server/DynamicFilterService.java Outdated Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/server/DynamicFilterService.java Outdated Show resolved Hide resolved
presto-main/src/test/java/io/prestosql/execution/scheduler/TestSourcePartitionedScheduler.java Outdated Show resolved Hide resolved
presto-main/src/test/java/io/prestosql/execution/scheduler/TestSourcePartitionedScheduler.java Outdated Show resolved Hide resolved
@sopel39 sopel39 force-pushed the ks/df_broadcast_joins branch from c5ad9f8 to 5b18e27 Compare September 15, 2020 12:43
@sopel39 sopel39 merged commit 1e37382 into trinodb:master Sep 15, 2020
@sopel39 sopel39 deleted the ks/df_broadcast_joins branch September 15, 2020 12:43
@sopel39 sopel39 mentioned this pull request Sep 15, 2020
Closed
9 tasks
@martint martint added this to the 342 milestone Sep 24, 2020
@rzeyde-varada rzeyde-varada mentioned this pull request Nov 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dain dain dain approved these changes

@raunaqmorarka raunaqmorarka Awaiting requested review from raunaqmorarka

@martint martint Awaiting requested review from martint

Assignees
No one assigned
Labels
cla-signed
Milestone
342
Development

Successfully merging this pull request may close these issues.
3 participants
@sopel39 @dain @martint