Implement parametric timestamp with time zone #3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
force-pushed
the
timestamptz-parametric
branch
4 times, most recently
from
1283aee to
7b8c2ea
Compare
martint
force-pushed
the
timestamptz-parametric
branch
6 times, most recently
from
9064e2b to
a3e7f0a
Compare
13 tasks
martint
force-pushed
the
timestamptz-parametric
branch
from
a3e7f0a to
b08b57b
Compare
martint
changed the title
martint
force-pushed
the
timestamptz-parametric
branch
3 times, most recently
from
a060f71 to
b4d6bf8
Compare
martint
force-pushed
the
timestamptz-parametric
branch
3 times, most recently
from
7320c9f to
7c11011
Compare
dain
reviewed
Jun 17, 2020
presto-main/src/main/java/io/prestosql/operator/scalar/timestamptz/DateDiff.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/operator/scalar/timestamptz/DateFormat.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/operator/scalar/timestamptz/DateTrunc.java
Show resolved
Hide resolved
presto-spi/src/main/java/io/prestosql/spi/type/LongTimestampWithTimeZone.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/io/prestosql/spi/type/LongTimestampWithTimeZone.java
Outdated
Show resolved
Hide resolved
dain
approved these changes
Jun 18, 2020
presto-spi/src/main/java/io/prestosql/spi/type/TimestampWithTimeZoneType.java
Show resolved
Hide resolved
presto-spi/src/main/java/io/prestosql/spi/type/TimestampWithTimeZoneType.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/io/prestosql/spi/type/SqlTimestampWithTimeZone.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/io/prestosql/spi/type/ShortTimestampWithTimeZoneType.java
Show resolved
Hide resolved
presto-spi/src/main/java/io/prestosql/spi/type/LongTimestampWithTimeZoneType.java
Outdated
Show resolved
Hide resolved
martint
force-pushed
the
timestamptz-parametric
branch
3 times, most recently
from
e4066ea to
2272346
Compare
Relying on ClientTypeSignature to render the string version of the type is brittle for any type with an irregular shape (e.g., timestamp(p) with time zone)
martint
force-pushed
the
timestamptz-parametric
branch
from
2272346 to
e8a000e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.