Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editing-mode option to CLI #3602

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Add editing-mode option to CLI #3602

merged 1 commit into from
Mar 11, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented May 3, 2020

Fixes #3377

@cla-bot cla-bot bot added the cla-signed label May 3, 2020
@ebyhr ebyhr requested a review from electrum May 5, 2020 03:11
@ebyhr
Copy link
Member Author

ebyhr commented Jan 5, 2022

@electrum Could you take a look when you have time?

@ebyhr ebyhr closed this Mar 1, 2022
@chancez
Copy link
Member

chancez commented Mar 10, 2022

I could see this through. @electrum any chance this could be considered for an upcoming release?

@chancez chancez reopened this Mar 10, 2022
hashhar
hashhar approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: static import EditingMode.

LGTM. It works for me (at-least the basics) and is useful IMO.

@chancez
Copy link
Member

chancez commented Mar 11, 2022

nit: static import EditingMode.

LGTM. It works for me (at-least the basics) and is useful IMO.

I'm not much of a Java developer, but if you tell me what I need to change I can do it!

@hashhar
Copy link
Member

hashhar commented Mar 11, 2022

nit: static import EditingMode.

Nevermind about this. I think the full import makes it clear it's coming from a ClientOptions.

@hashhar hashhar merged commit 396d249 into trinodb:master Mar 11, 2022
@hashhar hashhar mentioned this pull request Mar 11, 2022
Closed
@mosabua mosabua mentioned this pull request Mar 11, 2022
Merged
@github-actions github-actions bot added this to the 374 milestone Mar 11, 2022
@mosabua
Copy link
Member

mosabua commented Mar 12, 2022

@ebyhr please work with @Jessie212 on the PR for CLI options. She will integrate this option. #11187

@ebyhr ebyhr deleted the cli-mode branch March 12, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@electrum electrum electrum approved these changes

Assignees
No one assigned
Labels
cla-signed syntax-needs-review
Milestone
374
Development

Successfully merging this pull request may close these issues.

Add editing-mode property to switch between emacs/vi modes in presto-cli
5 participants
@ebyhr @chancez @hashhar @mosabua @electrum