Expose planningCpu time in QueryStats #3269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
reviewed
Mar 30, 2020
presto-main/src/main/java/io/prestosql/dispatcher/FailedDispatchQuery.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/execution/QueryStateMachine.java
Outdated
Show resolved
Hide resolved
sopel39
reviewed
Apr 2, 2020
presto-main/src/main/java/io/prestosql/execution/QueryStateMachine.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/execution/QueryStateTimer.java
Outdated
Show resolved
Hide resolved
puchengy
commented
Apr 3, 2020
presto-main/src/main/java/io/prestosql/execution/QueryStateTimer.java
Outdated
Show resolved
Hide resolved
sopel39
approved these changes
Apr 3, 2020
presto-main/src/main/java/io/prestosql/execution/QueryStateTimer.java
Outdated
Show resolved
Hide resolved
sopel39
changed the title
sopel39
reviewed
Apr 14, 2020
|
Ops, need to fix the test |
sopel39
reviewed
Apr 22, 2020
| @@ -36,6 +42,9 @@ | |||
| private final AtomicReference<Long> beginResourceWaitingNanos = new AtomicReference<>(); | |||
| private final AtomicReference<Long> beginDispatchingNanos = new AtomicReference<>(); | |||
| private final AtomicReference<Long> beginPlanningNanos = new AtomicReference<>(); | |||
| private final AtomicReference<Long> beginPlanningCpuNanos = new AtomicReference<>(); | |||
| private final AtomicReference<Long> beginPlanningThreadId = new AtomicReference<>(); | |||
| private final AtomicReference<Long> beginStartingThreadId = new AtomicReference<>(); | |||
There was a problem hiding this comment.
you don't need to store starting thread id. Just beginPlanningThreadId is enough
| planningTime.compareAndSet(null, nanosSince(beginPlanningNanos, now)); | ||
| planningCpuTime.compareAndSet(null, nanosSince(beginPlanningCpuNanos, cpuNow)); | ||
| beginStartingThreadId.compareAndSet(null, threadId); | ||
| if (!beginPlanningThreadId.get().equals(beginStartingThreadId.get())) { |
There was a problem hiding this comment.
Just use checkState as this should never happen
|
@Terry93 could you rebase? |
|
@Terry93 will you have time to complete this PR? |
|
@sopel39 Sorry about that, I completely forgot it. I will finish this one, thanks! |
|
👋 @puchengy - this PR is inactive and doesn't seem to be under development. If you'd like to continue work on this at any point in the future, feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #2579
I have a few questions, hope can have some ideas on what should be improved in this PR:
Is this the right way to measure CPU? I borrowed it from other places in the repo. And the underlying assumption is the planning is performed by a single thread.
Should we update this QueryCompleteEvent API to incorporate this as well? However
planning timeis not in the API as well.Do you think we should have a standalone unit test for this change (my answer is that it is not needed)?