add intelligent tiering storage class #3032
Conversation
| @@ -109,6 +111,7 @@ public void testExplicitPropertyMappings() | |||
| .setS3PathStyleAccess(true) | |||
| .setS3UseInstanceCredentials(false) | |||
| .setS3IamRole("roleArn") | |||
| .setS3StorageClass(PrestoS3StorageClass.INTELLIGENT_TIERING) | |||
There was a problem hiding this comment.
I guess we can import the enum directly
There was a problem hiding this comment.
@Praveen2112 Importing Enum directly might look off since PrestoS3SignerType and PrestoS3AclType are used without importing Enum directly.
| */ | ||
| package io.prestosql.plugin.hive.s3; | ||
|
|
||
| import com.amazonaws.services.s3.model.StorageClass; |
There was a problem hiding this comment.
| import com.amazonaws.services.s3.model.StorageClass; | |
| import com.amazonaws.services.s3.model.StorageClass.Standard; | |
| import com.amazonaws.services.s3.model.StorageClass.IntelligentTiering; |
There was a problem hiding this comment.
@Praveen2112 These statement below might look confusing if I import the storage classes Standard and IntelligentTiering directly
STANDARD(Standard),
INTELLIGENT_TIERING(IntelligentTiering);
Should I still change this?
There was a problem hiding this comment.
#2686 (comment) -- ie do not import them
| @@ -35,6 +35,7 @@ | |||
| private String s3AwsAccessKey; | |||
| private String s3AwsSecretKey; | |||
| private String s3Endpoint; | |||
| private PrestoS3StorageClass s3StorageClass = PrestoS3StorageClass.STANDARD; | |||
There was a problem hiding this comment.
Can we directly import the enum ?
There was a problem hiding this comment.
@Praveen2112 Importing Enum directly might look off since PrestoS3SignerType and PrestoS3AclType are used without importing Enum directly.
There was a problem hiding this comment.
if static import removes readability, it's should not be used;
here it is OK to static import, except it would be inconsistent. Please keep as is (inconsistency decreases readability)
|
Merged, thanks! |
Cherry pick of trinodb/trino#3032 Co-authored-by Arpit Solanki <[email protected]>
Cherry pick of trinodb/trino#3032 Co-authored-by Arpit Solanki <[email protected]>
Info on S3 Storage classes: https://aws.amazon.com/s3/storage-classes/
Cleaned up the PR #2686