Adding a regexp to match with each user group in resource control #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
requested changes
Mar 6, 2020
.../src/main/java/io/prestosql/plugin/resourcegroups/FileResourceGroupConfigurationManager.java
Outdated
Show resolved
Hide resolved
...o-resource-group-managers/src/main/java/io/prestosql/plugin/resourcegroups/SelectorSpec.java
Outdated
Show resolved
Hide resolved
...resource-group-managers/src/main/java/io/prestosql/plugin/resourcegroups/StaticSelector.java
Outdated
Show resolved
Hide resolved
...resource-group-managers/src/main/java/io/prestosql/plugin/resourcegroups/StaticSelector.java
Outdated
Show resolved
Hide resolved
.../test/java/io/prestosql/plugin/resourcegroups/TestFileResourceGroupConfigurationManager.java
Outdated
Show resolved
Hide resolved
...esource-group-managers/src/test/java/io/prestosql/plugin/resourcegroups/WithManagerSpec.java
Outdated
Show resolved
Hide resolved
...esource-group-managers/src/test/java/io/prestosql/plugin/resourcegroups/WithManagerSpec.java
Outdated
Show resolved
Hide resolved
...esource-group-managers/src/test/java/io/prestosql/plugin/resourcegroups/WithManagerSpec.java
Outdated
Show resolved
Hide resolved
...esource-group-managers/src/test/java/io/prestosql/plugin/resourcegroups/WithManagerSpec.java
Outdated
Show resolved
Hide resolved
MiguelWeezardo
force-pushed
the
user_groups_in_resource_selectors
branch
from
820fe24 to
731ac3b
Compare
|
does this fix #2919 ? |
electrum
reviewed
Mar 6, 2020
| return new SelectorSpecBuilder( | ||
| new SelectorSpec( | ||
| spec.getUserRegex(), | ||
| Optional.of(Pattern.compile(String.join("|", groups.stream().map(Pattern::quote).collect(Collectors.toList())))), |
There was a problem hiding this comment.
groups.stream().map(Pattern::quote).collect(joining("|"))
electrum
reviewed
Mar 6, 2020
| @Override | ||
| public String toString() | ||
| { | ||
| return new StringJoiner(", ", SelectionCriteria.class.getSimpleName() + "[", "]") |
It should make this possible if ldap groups are actually assigned to a user. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.