Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend SortExpressionExtractor for BETWEEN predicate #2859

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Extend SortExpressionExtractor for BETWEEN predicate #2859

merged 1 commit into from
Feb 19, 2020

Conversation

raunaqmorarka
Copy link
Member

This allows use of fast inequality join optimization when the range predicate is written as a BETWEEN clause.

Benchmark                                              (buckets)  (fastInequalityJoins)  (filterOutCoefficient)  Mode  Cnt     Score    Error  Units
BenchmarkInequalityJoin.benchmarkBetweenPredicateJoin        100                   true                      10  avgt   30    92.654 ± 13.636  ms/op
BenchmarkInequalityJoin.benchmarkBetweenPredicateJoin        100                  false                      10  avgt   30  1120.703 ± 32.170  ms/op
BenchmarkInequalityJoin.benchmarkBetweenPredicateJoin       1000                   true                      10  avgt   30    77.637 ±  6.043  ms/op
BenchmarkInequalityJoin.benchmarkBetweenPredicateJoin       1000                  false                      10  avgt   30   172.802 ±  4.488  ms/op
BenchmarkInequalityJoin.benchmarkBetweenPredicateJoin      10000                   true                      10  avgt   30    75.608 ±  7.518  ms/op
BenchmarkInequalityJoin.benchmarkBetweenPredicateJoin      10000                  false                      10  avgt   30    85.164 ±  7.538  ms/op
BenchmarkInequalityJoin.benchmarkBetweenPredicateJoin      60000                   true                      10  avgt   30    79.120 ± 13.802  ms/op
BenchmarkInequalityJoin.benchmarkBetweenPredicateJoin      60000                  false                      10  avgt   30    59.516 ±  5.242  ms/op

@cla-bot cla-bot bot added the cla-signed label Feb 17, 2020
@martint martint merged commit 5cb9de3 into trinodb:master Feb 19, 2020
@martint
Copy link
Member

martint commented Feb 19, 2020

Merged, thanks!

@martint martint added this to the 331 milestone Feb 19, 2020
@martint martint mentioned this pull request Feb 19, 2020
Closed
6 tasks
@raunaqmorarka raunaqmorarka deleted the between_ineq branch February 19, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
331
Development

Successfully merging this pull request may close these issues.
2 participants
@raunaqmorarka @martint