Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure QueryCompletedEvent occurs when query fails during planning #2842

Merged
merged 2 commits into from
Feb 20, 2020

Conversation

dain
Copy link
Member

@dain dain commented Feb 15, 2020

No description provided.

@JamesRTaylor
Copy link

LGTM. Thanks for cleaning this up, @dain.

public Iterable<ConnectorFactory> getConnectorFactories()
{
MockConnectorFactory connectorFactory = MockConnectorFactory.builder()
.withGetViews((session, schemaTablePrefix) -> ImmutableMap.of())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed

@dain dain force-pushed the query-completed-on-planning-failure branch from 2d5a812 to a801df2 Compare February 20, 2020 00:32
@dain dain merged commit 8a89c29 into trinodb:master Feb 20, 2020
@dain dain deleted the query-completed-on-planning-failure branch February 20, 2020 00:32
@dain dain added the bug Something isn't working label Feb 20, 2020
@dain dain mentioned this pull request Feb 20, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla-signed
Development

Successfully merging this pull request may close these issues.

3 participants