Add simple form based login page to UI #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
force-pushed
the
ui-login
branch
2 times, most recently
from
3c2c3ca to
62709dd
Compare
dain
force-pushed
the
ui-login
branch
2 times, most recently
from
bcbb146 to
2beb90c
Compare
electrum
approved these changes
Feb 13, 2020
presto-main/src/main/java/io/prestosql/server/ui/FormWebUiAuthenticationManager.java
Outdated
Show resolved
Hide resolved
| return Optional.empty(); | ||
| } | ||
|
|
||
| if (!isHttps(request)) { |
There was a problem hiding this comment.
We might want to fail here if a password was provided
There was a problem hiding this comment.
There is no "fail" in this code. We either take the login on redirect back to the login page. Which would you prefer?
presto-main/src/main/java/io/prestosql/server/ui/FormWebUiAuthenticationManager.java
Outdated
Show resolved
Hide resolved
| private static String getRedirectLocation(HttpServletRequest request, String path, String queryParameter) | ||
| { | ||
| String proto = firstNonNull(emptyToNull(request.getHeader(X_FORWARDED_PROTO)), request.getScheme()); | ||
| HttpUriBuilder builder = uriBuilder() |
There was a problem hiding this comment.
The JAX-RS builder is not a generic builder. It can't build a URI from raw parts, and instead builds URIs from templates or existing URIs.
presto-main/src/main/resources/webapp/src/components/PageTitle.jsx
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/io/prestosql/server/ui/TestWebUi.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/io/prestosql/server/ui/TestWebUi.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/io/prestosql/server/ui/TestWebUi.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.