Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline and catalog UDF docs #24496

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Dec 16, 2024

Description

I first tested catalog UDF with Python in the Trino CLI .. and that didnt work. So I completed the initial linked PR without the example that I am now adding here.

The thing I discovered is that it all works in DBeaver with the JDBC driver, so there must be some parsing issue in the CLI. Let me know if you want me to file a separate issue @electrum

Basically if I enter the query in the CLI to create the function .. I cant press enter to run it .. it just keeps adding empty lines

image

So I think we ideally should fix the CLI before the release or before we merge this PR.

Update.. I tested with an old CLI .. will verify with 468-snapshot version.

Further update @electrum - it works fine with CLI from 468 .. so.. do we need to document that somewhere ..

Additional context and related issues

#24441

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@mosabua
Copy link
Member Author

mosabua commented Dec 17, 2024

All updated.

@mosabua mosabua merged commit d961501 into trinodb:master Dec 17, 2024
4 of 8 checks passed
@mosabua mosabua deleted the catalogudf branch December 17, 2024 19:45
@github-actions github-actions bot added this to the 468 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants