Allow left side as update target in join pushdown #24447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
commented
Dec 11, 2024
core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/PushJoinIntoTableScan.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
fix_merge_join_pd
branch
6 times, most recently
from
0c6314c to
402e91e
Compare
chenjian2664
force-pushed
the
fix_merge_join_pd
branch
2 times, most recently
from
89373c4 to
b18857c
Compare
kokosing
approved these changes
Dec 16, 2024
chenjian2664
force-pushed
the
fix_merge_join_pd
branch
from
b18857c to
90e116c
Compare
Allow left side as update target when try to pushdown join into table scan. The change prevent the pushdown join into the table scan instead of throwing exception Co-Authored-By: Łukasz Osipiuk <[email protected]>
chenjian2664
force-pushed
the
fix_merge_join_pd
branch
from
90e116c to
9c77005
Compare
losipiuk
approved these changes
Dec 18, 2024
No - this is fine - approved - thanks. |
Actually - commit message could be changed - but too late - merged already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow left side as update target when try to pushdown join into table scan. This can happen because the
DELETEorUPDATEis planned as theMERGE, it's implemented contains the logic oftargetright join onsourcepart.Description
Close #17003
Additional context and related issues
Release notes
() This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: