Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Postgresql merge related tests #24429

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

chenjian2664
Copy link
Contributor

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Dec 10, 2024
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the 3rd commit to 2nd commit.

@ebyhr
Copy link
Member

ebyhr commented Dec 10, 2024

Commit title is too long. Please follow https://trino.io/development/process#pull-request-and-commit-guidelines-

@chenjian2664 chenjian2664 force-pushed the pg_merge_23034_ref branch 2 times, most recently from 286f0fc to 997c7a4 Compare December 10, 2024 09:53
@chenjian2664 chenjian2664 requested a review from ebyhr December 10, 2024 10:49
Inline method `addPrimaryKeyToCopyTable` in `TestPostgreSqlJdbcConnectionAccesses`
and `TestPostgreSqlJdbcConnectionCreation` for readability
@ebyhr ebyhr merged commit 90db2f5 into trinodb:master Dec 10, 2024
19 of 20 checks passed
@github-actions github-actions bot added this to the 468 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants