Revert "Fix parent project id handling" in BigQuery #24413
Merged
+4
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 74cce25.
|
@ebyhr Could yo run with secretes? |
|
/test-with-secrets sha=a0cda61fcc7e39a2395a18b13281d14c9756d32f |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/12232657383 |
ebyhr
changed the title
|
CI failure seems unrelated: @ebyhr Could you rerun? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts changes made by: #23041 which caused regression is required permissions.
After mentioned change jobs started to run on data project instead of previously parent project.
Running jobs required
BigQuery Job User (bigquery.jobs.create)permissions and in many setups such permissions can be added only on parent project level.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.