Improve JDBC performance + spooling polishing #23954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/jdbc-improvements
branch
from
cc111a0 to
06b52bb
Compare
Co-authored-by: Michiel De Smet <[email protected]>
Co-authored-by: Michiel De Smet <[email protected]>
wendigo
force-pushed
the
serafin/jdbc-improvements
branch
2 times, most recently
from
3354653 to
56111a7
Compare
wendigo
changed the title
losipiuk
reviewed
Oct 29, 2024
losipiuk
reviewed
Oct 29, 2024
core/trino-main/src/main/java/io/trino/server/protocol/spooling/SpooledQueryDataProducer.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 29, 2024
| @ConfigDescription("256 bit, base64-encoded secret key used to secure segment identifiers") | ||
| @Config("protocol.spooling.shared-secret-key") | ||
| @ConfigSecuritySensitive | ||
| public SpoolingConfig setSharedEncryptionKey(String sharedEncryptionKey) |
There was a problem hiding this comment.
nit: make getter and config name in line
losipiuk
approved these changes
Oct 29, 2024
Inlined pages are coalesced when fetched from the output task operator
wendigo
force-pushed
the
serafin/jdbc-improvements
branch
2 times, most recently
from
d951b59 to
91ecb9c
Compare
This avoids a round-trip Slice -> String -> UTF-8 byte[] written by Jackson
wendigo
force-pushed
the
serafin/jdbc-improvements
branch
from
91ecb9c to
b875959
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mdesmet
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: