Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iceberg migrate to use nullable columns #23928

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

raunaqmorarka
Copy link
Member

@raunaqmorarka raunaqmorarka commented Oct 26, 2024

Description

Previous logic was setting all columns as non-nullable which is not valid when the data contains nulls

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Iceberg
* Fix migrate for tables which contain NULLs. ({issue}`23928`)

Previous logic was setting all columns as non-nullable
which is not valid when the data contains nulls
@cla-bot cla-bot bot added the cla-signed label Oct 26, 2024
@github-actions github-actions bot added the iceberg Iceberg connector label Oct 26, 2024
@raunaqmorarka raunaqmorarka added the bug Something isn't working label Oct 26, 2024
@raunaqmorarka raunaqmorarka merged commit e3b62bd into master Oct 27, 2024
44 checks passed
@raunaqmorarka raunaqmorarka deleted the migrate-fix branch October 27, 2024 01:39
@github-actions github-actions bot added this to the 464 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

3 participants