Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Faker connector #23901

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

nineinchnick
Copy link
Member

Description

Follow-up to #23691

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Oct 24, 2024
@github-actions github-actions bot added the docs label Oct 24, 2024
@nineinchnick
Copy link
Member Author

@mosabua I ran the Vale linter on this, but haven't tested it locally yet. I'll do that after the first review, as I'm sure there will be lots of changes.

@nineinchnick nineinchnick requested a review from mosabua October 24, 2024 17:47
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review with ideas and changes.

docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments.. will ping you on slack

docs/src/main/sphinx/connector/faker.md Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
@nineinchnick nineinchnick force-pushed the faker-docs branch 2 times, most recently from 6375ced to aa57dd4 Compare October 28, 2024 19:24
@nineinchnick nineinchnick requested a review from mosabua October 28, 2024 19:24
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Show resolved Hide resolved
docs/src/main/sphinx/connector/faker.md Outdated Show resolved Hide resolved
@nineinchnick nineinchnick force-pushed the faker-docs branch 2 times, most recently from dc352e7 to 81d2a3a Compare October 29, 2024 19:13
@nineinchnick
Copy link
Member Author

Good to go!

@nineinchnick nineinchnick force-pushed the faker-docs branch 2 times, most recently from 4540a97 to 3da746d Compare October 30, 2024 14:26
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. We might expand in a follow up but this is definitely a great first doc set for the connector.

@mosabua mosabua merged commit 22640c5 into trinodb:master Oct 30, 2024
6 of 8 checks passed
@github-actions github-actions bot added this to the 464 milestone Oct 30, 2024
@nineinchnick nineinchnick deleted the faker-docs branch October 30, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants