-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the Faker connector #23901
Document the Faker connector #23901
Conversation
@mosabua I ran the Vale linter on this, but haven't tested it locally yet. I'll do that after the first review, as I'm sure there will be lots of changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review with ideas and changes.
ba4b722
to
f8cc34b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments.. will ping you on slack
6375ced
to
aa57dd4
Compare
dc352e7
to
81d2a3a
Compare
81d2a3a
to
3424de3
Compare
3424de3
to
19e335c
Compare
Good to go! |
4540a97
to
3da746d
Compare
3da746d
to
e394f77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now. We might expand in a follow up but this is definitely a great first doc set for the connector.
Description
Follow-up to #23691
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: