Reduce synchronization for metadata calls in SemiTransactionalHiveMetastore #23890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
force-pushed
the
hive-sync
branch
from
2cee4ea to
ea66a4a
Compare
hashhar
approved these changes
Oct 24, 2024
Yes, I only updated what was necessary for now. I expect we will eventually refactor most of this if/when we remove multi-statement commands and ACID from hive, so trying to avoid big changes for now. |
…astore We don't need to hold lock on SemiTransactionalHiveMetastore object for remote calls which just read metadata. Listing views/tables/databases on metastore can be potentially slow. Holding lock blocks cleanupQuery, which prevents QueryTracker#enforceTimeLimits from failing queries which exceed time limit.
raunaqmorarka
force-pushed
the
hive-sync
branch
from
ea66a4a to
ab76e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't need to hold lock on SemiTransactionalHiveMetastore object for remote calls which just read metadata. Listing views/tables/databases on metastore can be potentially slow. Holding lock blocks cleanupQuery, which prevents QueryTracker#enforceTimeLimits from failing queries which exceed time limit.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.