Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for internal communication #23879

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Oct 23, 2024

Description

See title, adding since we are switching to HTTP/2 by default now and need to docs for switching back if desired.

After discussion with @electrum we decided to go ahead with the second commit and remove the info about manual config for internal TLS.

Additional context and related issues

Related to #21793

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Oct 23, 2024
@github-actions github-actions bot added the docs label Oct 23, 2024
@mosabua mosabua force-pushed the internal branch 2 times, most recently from e4ad255 to 101c701 Compare October 23, 2024 18:41
@mosabua mosabua requested review from dain and wendigo October 23, 2024 18:41
@mosabua mosabua marked this pull request as ready for review October 23, 2024 18:41
@mosabua mosabua changed the title Document props for internal communication Update docs for internal communication Oct 23, 2024
@mosabua mosabua force-pushed the internal branch 2 times, most recently from 40bf458 to a807aae Compare October 23, 2024 18:51
@mosabua mosabua force-pushed the internal branch 5 times, most recently from 4b16e19 to 69361fa Compare October 23, 2024 19:31
@mosabua
Copy link
Member Author

mosabua commented Oct 25, 2024

ping @wendigo and @dain

Add properties to HTTP server props page including HTTP/2 details.
@mosabua
Copy link
Member Author

mosabua commented Oct 29, 2024

Adjusted as discussed @electrum .. please approve so we can merge.

Automatic internal config has been in place for a long time.
Discussed with David Phillips and decided to remove this
last hint that manual config is even possible.
@mosabua mosabua merged commit 0bd992d into trinodb:master Oct 30, 2024
3 of 8 checks passed
@mosabua mosabua deleted the internal branch October 30, 2024 23:08
@github-actions github-actions bot added this to the 464 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants