-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable spooling filesystem layout implementations #23784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Oct 15, 2024
...-spooling-filesystem/src/main/java/io/trino/spooling/filesystem/FileSystemSegmentPruner.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 15, 2024
...spooling-filesystem/src/main/java/io/trino/spooling/filesystem/FileSystemSpoolingConfig.java
Show resolved
Hide resolved
losipiuk
reviewed
Oct 15, 2024
...pooling-filesystem/src/main/java/io/trino/spooling/filesystem/FileSystemSpoolingManager.java
Show resolved
Hide resolved
losipiuk
reviewed
Oct 15, 2024
...spooling-filesystem/src/main/java/io/trino/spooling/filesystem/FileSystemSpoolingModule.java
Show resolved
Hide resolved
losipiuk
reviewed
Oct 15, 2024
...oling-filesystem/src/main/java/io/trino/spooling/filesystem/PartitionedFileSystemLayout.java
Show resolved
Hide resolved
losipiuk
reviewed
Oct 15, 2024
...-spooling-filesystem/src/main/java/io/trino/spooling/filesystem/PartitionedLayoutConfig.java
Show resolved
Hide resolved
losipiuk
reviewed
Oct 15, 2024
...o-spooling-filesystem/src/main/java/io/trino/spooling/filesystem/SimpleFileSystemLayout.java
Show resolved
Hide resolved
losipiuk
reviewed
Oct 15, 2024
...oling-filesystem/src/test/java/io/trino/spooling/filesystem/TestFileSystemSegmentPruner.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
wendigo
force-pushed
the
serafin/add-spooling-layouts
branch
from
October 15, 2024 20:24
956e293
to
c2ba564
Compare
wendigo
force-pushed
the
serafin/add-spooling-layouts
branch
from
October 15, 2024 20:44
c2ba564
to
00d8d04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: