Add module info to SPI #23767
Merged
Add module info to SPI #23767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Oct 12, 2024
| requires transitive com.google.errorprone.annotations; | ||
| requires transitive io.opentelemetry.api; | ||
| requires transitive jakarta.annotation; | ||
| requires transitive java.logging; |
There was a problem hiding this comment.
I assume you mean for this specific import. If so, yes I think you are correct and this one should not be transitive.
There was a problem hiding this comment.
What about the others, such as error prone annotations, Jakarta annotations, etc
wendigo
reviewed
Oct 13, 2024
wendigo
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first step to convert the SPI and generally the plugin system into Java modules. This allows for better encapsulation of the plugins and Trino internals. For example, as a module the SPI can have a non-exported package containing internal utility classes shared across SPI packages. Additionally, in an automatic module, like the SPI, sealed class hiearchies can must be contained in a single package.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.