-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move timestamp to the left #23744
Move timestamp to the left #23744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result seems fine. I assume you tested it with resizing the window and it behaves ok.
Ideally we would avoid using negative margin values and figure out what is causing the right hand code block to overlap into it or be so close - but given this is our legacy UI I am fine with this fix.
This seems to have broken in a recent change. It used to look ok before. Do we know what broke it? Can we address the underlying issue instead? |
My gut feeling tells me it has to do with the syntax highlighting we added to the list. |
Hm .. weirdly I am not observing the spacing issue in #23748 .. see the screenshots there. Update .. I see it now as well.. |
@@ -426,6 +426,7 @@ pre { | |||
.query-header-timestamp { | |||
text-align: right; | |||
color: #b1b1b1; | |||
margin-left: -15px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that .query also has the margin-left .. I wonder what happens if we remove that there instead..
Turns out those negative margins (paired with identical value positive padding) are everywhere .. all the way up into the .row setup of bootstrap .. so I think we just ship this since its working. Cleaning up that CSS is probably a waste of time. |
@martint my change broke the height and the position of a date |
Description
Before:
After:
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.