Decouple QueryData on the wire from decoding #23743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/null-raw-query
branch
from
33163b2 to
89e0e04
Compare
losipiuk
reviewed
Oct 10, 2024
losipiuk
reviewed
Oct 10, 2024
client/trino-client/src/main/java/io/trino/client/RawQueryData.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 10, 2024
client/trino-client/src/main/java/io/trino/client/ResultRows.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 10, 2024
client/trino-client/src/main/java/io/trino/client/ResultRows.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 10, 2024
client/trino-client/src/main/java/io/trino/client/ResultRows.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 10, 2024
client/trino-client/src/main/java/io/trino/client/ResultRowsDecoder.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 10, 2024
client/trino-client/src/main/java/io/trino/client/ResultRowsDecoder.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 10, 2024
wendigo
force-pushed
the
serafin/null-raw-query
branch
from
89e0e04 to
5dc7670
Compare
Previously the same interface (QueryData) was both used to represent data on the wire (QueryResults.data field) and access result rows on the StatementClient via currentData(). This was wrong as the on the wire representation for spooled protocol does not carry actual result rows but merely represent the location of the data. This was confusing as the QueryData getData() implementation was throwing an exception in that case. After this change, QueryData was split into two interfaces: one representing data on the wire (QueryData) and the other one representing actual result rows (ResultRows). There is now a single place responsible for decoding QueryData representations to actual result rows (ResultRowsDecoder).
wendigo
force-pushed
the
serafin/null-raw-query
branch
from
5dc7670 to
4c57289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the same interface (QueryData) was both used to represent
data on the wire (QueryResults.data field) and access result rows
on the StatementClient via currentData(). This was wrong as the on the wire
representation for spooled protocol does not carry actual result rows
but merely represent the location of the data. This was confusing
as the QueryData getData implementation was throwing an exception
in that case. After this change, QueryData was split into two interfaces:
one representing data on the wire (QueryData) and the other one representing
actual result rows (QueryResultRows). There is now a single place responsible
for decoding QueryData representations to actual result rows.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: