Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of generated PagesHashStrategy constructor #23720

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

martint
Copy link
Member

@martint martint commented Oct 8, 2024

Move the code for calculating the retained size to a separate method implemented as a loop, instead of unrolling the calls.

Relates to #15848

Release notes

* Fix failure when joining tables with large numbers of columns. ({issue}`23720`)

Move the code for calculating the retained size to a separate
method implemented as a loop, instead of unrolling the calls.
@martint martint merged commit c0aa7d9 into trinodb:master Oct 9, 2024
93 checks passed
@martint martint deleted the pages-hash-strategy branch October 9, 2024 06:47
@github-actions github-actions bot added this to the 461 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants