Remove unnecessary Block getLogicalSizeInBytes #23688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only used in a few places, and was not implement correctly in several container block implementations.
dain
commented
Oct 6, 2024
| @@ -577,6 +586,38 @@ private synchronized QueryResultRows removePagesFromExchange(ResultQueryInfo que | |||
| return resultBuilder.build(); | |||
| } | |||
|
|
|||
| private static long estimateJsonSize(Page page) | |||
There was a problem hiding this comment.
@wendigo I'm not sure if we really need this. Of the 3 usages, this is the only one where I could see it mattering (assuming logical size was actually implemented correctly).
There was a problem hiding this comment.
As far as I understand this code, we are trying to produce a JSON from a Page that has a logical size of the targetResultBytes. If the block is using dictionary encoding this could produce much bigger JSON which can affect the existing protocol. In the spooled protocol we don't care much about these cases and use the page size instead. The change you've made here is good enough as this is suppose to be an estimate anyway.
wendigo
approved these changes
Oct 6, 2024
electrum
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was only used in a few places, and was not implement correctly in several container block implementations.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: