Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client libraries to JDK 11 #23639

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Update client libraries to JDK 11 #23639

merged 1 commit into from
Jan 28, 2025

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Oct 1, 2024

Description

JDK 11 was released 6 years ago. Enough time has passed for industry to pick it up. Let's move to JDK 11.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Oct 1, 2024
@wendigo wendigo requested review from electrum and martint October 1, 2024 20:39
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label Oct 1, 2024
@mosabua
Copy link
Member

mosabua commented Oct 1, 2024

I agree with this but think we probably want to ask in the community and check some client applications and see what they require as JDK. I would think that most, if not all maintained applications require 11 or even newer .. probably 17.

Here are some useful stats - https://newrelic.com/resources/report/2024-state-of-the-java-ecosystem

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Oct 23, 2024
@mosabua
Copy link
Member

mosabua commented Oct 23, 2024

We are discussing this at the upcoming contributor call on the 24 of Oct 2024

@github-actions github-actions bot removed the stale label Oct 24, 2024
@wendigo wendigo force-pushed the serafin/client-jdk-11 branch from 21f35a8 to 564f2f0 Compare November 4, 2024 12:20
@wendigo
Copy link
Contributor Author

wendigo commented Nov 4, 2024

@mosabua can we announce that we want to do that during trino summit?

@mosabua
Copy link
Member

mosabua commented Nov 4, 2024

@mosabua can we announce that we want to do that during trino summit?

Yes .. latest and also then. I just started prepping for the keynote .. this should be part of it - cc @martint @dain @electrum

@wendigo
Copy link
Contributor Author

wendigo commented Nov 4, 2024

@mosabua great, thank you!

Copy link

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

@github-actions github-actions bot added the stale label Nov 26, 2024
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Dec 17, 2024
@wendigo wendigo reopened this Dec 17, 2024
@wendigo wendigo added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Dec 17, 2024
@wendigo
Copy link
Contributor Author

wendigo commented Dec 17, 2024

@martint @mosabua did we land on the conclusion?

@mosabua
Copy link
Member

mosabua commented Dec 17, 2024

Not yet .. but I am working on a survey for the end of year blog post.

@wendigo wendigo force-pushed the serafin/client-jdk-11 branch from 564f2f0 to c334177 Compare January 13, 2025 13:50
@wendigo wendigo requested a review from mosabua January 22, 2025 11:43
@mosabua
Copy link
Member

mosabua commented Jan 22, 2025

We discussed this some more and also added a question to the user survey in https://trino.io/blog/2025/01/07/2024-and-beyond

Here are the results for the client library question

java-client

As a result we can conclude that we are definitely safe to upgrade to Java 11 as requirement as implemented in this PR. Over 90% have no issues with the upgrade and the rest of the users can continue to use older drivers until they can upgrade.

In terms of merging I suggest we release Trino 469 and merge this PR afterwards.

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lets ship with 470. Also see my comment for further data.

@wendigo wendigo merged commit 8c9401b into master Jan 28, 2025
104 checks passed
@wendigo wendigo deleted the serafin/client-jdk-11 branch January 28, 2025 08:44
@github-actions github-actions bot added this to the 470 milestone Jan 28, 2025
@mosabua
Copy link
Member

mosabua commented Jan 28, 2025

💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed jdbc Relates to Trino JDBC driver stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Development

Successfully merging this pull request may close these issues.

2 participants