-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update client libraries to JDK 11 #23639
Conversation
I agree with this but think we probably want to ask in the community and check some client applications and see what they require as JDK. I would think that most, if not all maintained applications require 11 or even newer .. probably 17. Here are some useful stats - https://newrelic.com/resources/report/2024-state-of-the-java-ecosystem |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
We are discussing this at the upcoming contributor call on the 24 of Oct 2024 |
21f35a8
to
564f2f0
Compare
@mosabua can we announce that we want to do that during trino summit? |
@mosabua great, thank you! |
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
Not yet .. but I am working on a survey for the end of year blog post. |
564f2f0
to
c334177
Compare
We discussed this some more and also added a question to the user survey in https://trino.io/blog/2025/01/07/2024-and-beyond Here are the results for the client library question ![]() As a result we can conclude that we are definitely safe to upgrade to Java 11 as requirement as implemented in this PR. Over 90% have no issues with the upgrade and the rest of the users can continue to use older drivers until they can upgrade. In terms of merging I suggest we release Trino 469 and merge this PR afterwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Lets ship with 470. Also see my comment for further data.
💥 |
Description
JDK 11 was released 6 years ago. Enough time has passed for industry to pick it up. Let's move to JDK 11.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: