Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge BaseOracleCastPushdownTest into TestOracleCastPushdown #23612

Merged

Conversation

krvikash
Copy link
Contributor

@krvikash krvikash commented Sep 30, 2024

Description

Merge BaseOracleCastPushdownTest into TestOracleCastPushdown, Since BaseOracleCastPushdownTest was getting inherited by only one class.

Release notes

(X) This is not user-visible or is docs only, and no release notes are required.

@krvikash krvikash force-pushed the krvikash/oracle-cast-pushdown-cosmetic-change branch from 3940fe4 to e9ccfd3 Compare October 1, 2024 05:35
@ebyhr ebyhr changed the title Move testCastPushdownWithForcedTypedToVarchar in child class Merge BaseOracleCastPushdownTest into TestOracleCastPushdown Oct 1, 2024
@krvikash krvikash force-pushed the krvikash/oracle-cast-pushdown-cosmetic-change branch from e9ccfd3 to 411d2fa Compare October 1, 2024 05:36
@ebyhr ebyhr merged commit ba8516b into trinodb:master Oct 1, 2024
15 checks passed
@krvikash krvikash deleted the krvikash/oracle-cast-pushdown-cosmetic-change branch October 1, 2024 06:16
@github-actions github-actions bot added this to the 460 milestone Oct 1, 2024
@mosabua mosabua mentioned this pull request Oct 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants