Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache NodeJS in GHA #23609

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Cache NodeJS in GHA #23609

merged 2 commits into from
Sep 30, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Sep 30, 2024

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Sep 30, 2024
@github-actions github-actions bot added the ui Web UI label Sep 30, 2024
@wendigo
Copy link
Contributor Author

wendigo commented Sep 30, 2024

Seems like cache is saved:

Screenshot 2024-09-30 at 14 32 51

@wendigo
Copy link
Contributor Author

wendigo commented Sep 30, 2024

Restored:

Screenshot 2024-09-30 at 14 51 54

And used:

Screenshot 2024-09-30 at 14 52 43

@wendigo
Copy link
Contributor Author

wendigo commented Sep 30, 2024

It should help with frequent CI failures due to "premature end of file" while fetching NodeJS

@wendigo
Copy link
Contributor Author

wendigo commented Sep 30, 2024

The positive side effect is that NodeJS package is installed in the .node directory which is not cleared which makes the trino-web-ui build faster.

@wendigo
Copy link
Contributor Author

wendigo commented Sep 30, 2024

I've restarted build to see if cache is picked up

@wendigo wendigo merged commit b43e2a3 into master Sep 30, 2024
100 of 103 checks passed
@wendigo wendigo deleted the serafin/npm-cache branch September 30, 2024 15:50
@github-actions github-actions bot added this to the 460 milestone Sep 30, 2024
@mosabua mosabua mentioned this pull request Oct 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants