Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify boolean assertions #23595

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Sep 28, 2024

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Sep 28, 2024
@github-actions github-actions bot added jdbc Relates to Trino JDBC driver iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector mongodb MongoDB connector labels Sep 28, 2024
@ebyhr ebyhr force-pushed the ebi/test-optional-assertion branch from b0d2178 to 398770a Compare September 28, 2024 03:04
@ebyhr ebyhr force-pushed the ebi/test-optional-assertion branch from 398770a to 0f32444 Compare September 28, 2024 03:06
@wendigo
Copy link
Contributor

wendigo commented Sep 29, 2024

I've skimmed through these changes and looks fine to me. Did you use some automation tool/sed to make these?

@ebyhr
Copy link
Member Author

ebyhr commented Sep 29, 2024

I replaced most of the changes with regexp on IDE and fixed them partially by hand.

@ebyhr ebyhr merged commit 64e4e7b into trinodb:master Sep 29, 2024
95 checks passed
@ebyhr ebyhr deleted the ebi/test-optional-assertion branch September 29, 2024 23:50
@github-actions github-actions bot added this to the 460 milestone Sep 29, 2024
@mosabua mosabua mentioned this pull request Oct 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector jdbc Relates to Trino JDBC driver mongodb MongoDB connector
Development

Successfully merging this pull request may close these issues.

2 participants