Store metadata when listing columns/comments in Delta Lake #23589
+77
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/delta-store-metadata
branch
from
3fd0d60 to
d4abb5f
Compare
anusudarsan
approved these changes
Sep 27, 2024
findinpath
reviewed
Sep 30, 2024
...rc/test/java/io/trino/plugin/deltalake/metastore/TestDeltaLakeMetastoreAccessOperations.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Sep 30, 2024
...rc/test/java/io/trino/plugin/deltalake/metastore/TestDeltaLakeMetastoreAccessOperations.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/delta-store-metadata
branch
from
d4abb5f to
5d3f0ac
Compare
findinpath
reviewed
Oct 3, 2024
| @@ -783,12 +826,35 @@ public void testSystemMetadataTableComments() | |||
| assertUpdate(session, "INSERT INTO test_select_s_m_t_comments" + i + " VALUES ('xyz', 12)", 1); | |||
|
|
|||
| assertUpdate(session, "CREATE TABLE test_other_select_s_m_t_comments" + i + "(id varchar, age integer)"); // won't match the filter | |||
|
|
|||
| if (removeCachedProperties) { | |||
There was a problem hiding this comment.
It took me a bit to understand the purpose of removeCachedProperties in testSystemMetadataTableComments() method.
I understand though now the purpose - we want to verify how the system.metadata.table_comments query behaves when the table comments are added filled one by one as well as when they are added in bulk.
findinpath
approved these changes
Oct 3, 2024
wendigo
reviewed
Oct 3, 2024
...in/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeFileOperations.java
Outdated
Show resolved
Hide resolved
wendigo
approved these changes
Oct 3, 2024
wendigo
approved these changes
Oct 3, 2024
ebyhr
force-pushed
the
ebi/delta-store-metadata
branch
from
5d3f0ac to
e8b858a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Store metadata when listing columns/comments in Delta Lake
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.