Remove Raptor legacy connector #23588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
YES! |
wendigo
approved these changes
Sep 27, 2024
|
Look at that .. all green. Not even failures from flaky, unrelated tests. I won the lotto... |
|
We requested user input on slack and linkedin to find out if anyone uses this plugin now. |
electrum
approved these changes
Sep 27, 2024
| @@ -41,15 +41,6 @@ public static OutputStreamOrcDataSink create(TrinoOutputFile outputFile) | |||
| return new OutputStreamOrcDataSink(outputFile.create(memoryContext), memoryContext); | |||
| } | |||
|
|
|||
| // Do not use this method, it is here only for io.trino.plugin.raptor.legacy.storage.OrcFileWriter.createOrcDataSink | |||
| // and it should be removed in the future | |||
| @Deprecated | |||
raunaqmorarka
approved these changes
Oct 1, 2024
The connector has no known users and forces some complexities on the rest of the codebase. To allow this next clean up steps the connector is removed. In a contributor call, on slack, and in other conversations no concerns were expressed by anybody about the removal.
|
YEAH! |
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The connector has no known use and forces some complexities on the rest of the codebase. Do allow next clean up steps the connector is removed.
In a contributor call, on slack, and in other conversations no concerns were expressed by anybody about the removal.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: