Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip release 456 in compatibility checks #23577

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Skip release 456 in compatibility checks #23577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...uncher/src/main/java/io/trino/tests/product/launcher/suite/suites/SuiteCompatibility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ private static List<TestedImage> testedTrinoDockerImages()
ImmutableList.Builder<TestedImage> testedTrinoVersions = ImmutableList.builder();
int testVersion = currentVersion - 1; // always test last release version
for (int i = 0; i < NUMBER_OF_TESTED_VERSIONS; i++) {
if (testVersion == 404) {
ebyhr marked this conversation as resolved.
Show resolved Hide resolved
// 404 release was skipped.
if (testVersion == 456) {
// 456 release was skipped.
testVersion--;
}
if (testVersion < FIRST_TRINO_VERSION) {
Expand Down
4 changes: 2 additions & 2 deletions ...patibility-old-server/src/test/java/io/trino/TestJdbcResultSetCompatibilityOldServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ public static Object[][] testedTrinoVersions()
ImmutableList.Builder<String> testedTrinoVersions = ImmutableList.builder();
int testVersion = currentVersion - 1; // last release version
for (int i = 0; i < NUMBER_OF_TESTED_VERSIONS; i++) {
if (testVersion == 404) {
// 404 release was skipped.
if (testVersion == 456) {
// 456 release was skipped.
testVersion--;
}
if (testVersion < FIRST_VERSION) {
Expand Down
Loading