Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client cleanup / improvements #23569

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Client cleanup / improvements #23569

merged 7 commits into from
Sep 26, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Sep 25, 2024

This improves JDBC client throughput a bit.

Benchmarked using simple tool: https://github.com/wendigo/trino-jdbc-benchmark

Before:

Average time for 10 runs: 14371ms

After:

Average time for 10 runs: 13003ms

@cla-bot cla-bot bot added the cla-signed label Sep 25, 2024
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label Sep 25, 2024
@wendigo wendigo changed the title Serafin/client cleanup Client cleanup / improvements Sep 25, 2024
@wendigo wendigo force-pushed the serafin/client-cleanup branch from 1ad963c to f5326e2 Compare September 26, 2024 05:20
@wendigo wendigo merged commit 572eb0b into master Sep 26, 2024
104 of 108 checks passed
@wendigo wendigo deleted the serafin/client-cleanup branch September 26, 2024 10:46
@github-actions github-actions bot added this to the 460 milestone Sep 26, 2024
@mosabua
Copy link
Member

mosabua commented Sep 27, 2024

RN about performance improvement @wendigo ?

@mosabua mosabua mentioned this pull request Sep 27, 2024
1 task
@wendigo
Copy link
Contributor Author

wendigo commented Sep 27, 2024

@mosabua nope :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed jdbc Relates to Trino JDBC driver
Development

Successfully merging this pull request may close these issues.

3 participants