Simplify schema field in HiveSplit for ORC, Parquet and RCFile tables #23561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
reviewed
Sep 26, 2024
plugin/trino-hive/src/main/java/io/trino/plugin/hive/Schema.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
hive-schema
branch
from
ddcfb61 to
ad22b3b
Compare
Praveen2112
approved these changes
Sep 30, 2024
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/InternalHiveSplitFactory.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
hive-schema
branch
2 times, most recently
from
8e1827c to
ac7c17b
Compare
losipiuk
approved these changes
Sep 30, 2024
Extract the required properties for ORC, Parquet and RCFile into explicit fields and use a Map only when necessary. This avoids repeated look-ups in schema Map and reduces size of HiveSplit for the more common cases.
raunaqmorarka
force-pushed
the
hive-schema
branch
from
ac7c17b to
9d24ca8
Compare
Praveen2112
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract the required properties for ORC, Parquet and RCFile into explicit fields and use a Map only when necessary.
This avoids repeated look-ups in schema Map and reduces size of HiveSplit for the more common cases.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: