Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WASBS to native Azure file system implementation #23548

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

mrcnc
Copy link
Member

@mrcnc mrcnc commented Sep 24, 2024

Description

As a follow up to #23535, this PR adds the wasbs scheme as an alias for the Azure native file system implementation as recommended here.

Additional context and related issues

The s in wasbs implies that TLS will be used, similar to abfss or https. The code will function the same if a path uses wasb or wasbs since it will still leverage the Azure Data Lake Storage Gen2 REST APIs

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link

cla-bot bot commented Sep 24, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@mrcnc
Copy link
Member Author

mrcnc commented Sep 24, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

I emailed the signed CLA last week and haven't heard anything back yet

@anusudarsan
Copy link
Member

@martint can we merge this after approving CLA?

@martint
Copy link
Member

martint commented Oct 2, 2024

@cla-bot check

Copy link

cla-bot bot commented Oct 2, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Oct 2, 2024

The cla-bot has been summoned, and re-checked this pull request!

@martint
Copy link
Member

martint commented Oct 2, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Oct 2, 2024
Copy link

cla-bot bot commented Oct 2, 2024

The cla-bot has been summoned, and re-checked this pull request!

@martint martint merged commit 5ceaffb into trinodb:master Oct 2, 2024
58 checks passed
@github-actions github-actions bot added this to the 460 milestone Oct 2, 2024
@mrcnc mrcnc deleted the add-wasbs-support branch October 2, 2024 17:57
@mosabua mosabua mentioned this pull request Oct 2, 2024
1 task
@mosabua
Copy link
Member

mosabua commented Oct 2, 2024

I added a release notes entry ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants