Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch dependency updates #23435

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Batch dependency updates #23435

merged 5 commits into from
Sep 16, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Sep 16, 2024

No description provided.

@losipiuk
Copy link
Member

@martint please comment on tzdb change. I do not know if we can do anything about it. But if that may be problematic to users then we should at least do some communication.

@wendigo
Copy link
Contributor Author

wendigo commented Sep 16, 2024

@Praveen2112
Copy link
Member

Should we update our connector tests to match with these special timezone representation and like

Asia/Choibalsan is now an alias for Asia/Ulaanbaatar

Historical transitions for Mexico have been updated based on
official Mexican decrees

@wendigo wendigo force-pushed the serafin/16-sep-updates branch from a173507 to 160e7b8 Compare September 16, 2024 10:31
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label Sep 16, 2024
@wendigo
Copy link
Contributor Author

wendigo commented Sep 16, 2024

@Praveen2112 we don't, they are already there (check zone-index.properties)

@wendigo wendigo force-pushed the serafin/16-sep-updates branch from 160e7b8 to dc22f21 Compare September 16, 2024 12:45
@wendigo
Copy link
Contributor Author

wendigo commented Sep 16, 2024

joda-time update requires updated tzdata in JVM which is not possible due to https://bugs.openjdk.org/browse/JDK-8339645

@wendigo wendigo merged commit 1bf896f into master Sep 16, 2024
105 of 107 checks passed
@wendigo wendigo deleted the serafin/16-sep-updates branch September 16, 2024 14:52
@github-actions github-actions bot added this to the 458 milestone Sep 16, 2024
@Praveen2112
Copy link
Member

@wendigo Thanks for the pointers - the zone-index.properties is on the Trino side for processing - I was a bit confused by this line

The affected timestamps occur during
the years 1921-1927, 1931, 1945, 1949-1970, and 1981-1997.

Does it mean the datasources which happens to store the data during the time period in a Mexcian timezone would translate them differently.

@wendigo
Copy link
Contributor Author

wendigo commented Sep 16, 2024

@Praveen2112 yes, basically the "JVM gap" disappeared for that timezone and 1970-01-01 date which renders some of the tests unusable.

@Praveen2112
Copy link
Member

Okay - But can we capture them as additional test cases, maybe as a follow-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed jdbc Relates to Trino JDBC driver
Development

Successfully merging this pull request may close these issues.

3 participants