Extract SystemTableProvider from Hive #23380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
iceberg
Dith3r
force-pushed
the
ke/iceberg-st
branch
from
38dcca3 to
47eff89
Compare
ksobolew
reviewed
Sep 12, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/RawSystemTableProvider.java
Outdated
Show resolved
Hide resolved
Dith3r
force-pushed
the
ke/iceberg-st
branch
2 times, most recently
from
fc5c9b5 to
08c3d65
Compare
|
CI failure: #22861 |
Dith3r
force-pushed
the
ke/iceberg-st
branch
from
08c3d65 to
d169786
Compare
core/trino-spi/src/main/java/io/trino/spi/connector/SystemTableProvider.java
Outdated
Show resolved
Hide resolved
Dith3r
force-pushed
the
ke/iceberg-st
branch
from
d169786 to
74a01e7
Compare
Dith3r
force-pushed
the
ke/iceberg-st
branch
from
74a01e7 to
c22268e
Compare
Dith3r
changed the title
raunaqmorarka
approved these changes
Sep 12, 2024
wendigo
approved these changes
Sep 12, 2024
|
What is the reasoning for this change? Do you have plans to use this for other connectors? If we don't have any near-term plans, then let's revert this, and it can be added when it will be used. |
|
Also, there is a cost to sharing code, and seemingly no benefit here. What's the usefulness in extracting an interface that will be used independently by different connectors? There is no shared implementation that would need to be fixed in multiple places. But if we need to make a change to one of the connectors but not the others, the artificial coupling here makes that change harder. If you need a similar internal interface in another connector, simply copy the (two method) interface to the other connector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to define system table providers for Iceberg similar to Hive.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: