Fix NPE in ThriftMetastoreUtil to provide proper error message #23371
+34
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in some cases when Hive partition metadata is corrupted such that a storage descriptor is present, but it doesn't have
columns
set, you will get an NPE thrown from Trino:This PR adds a check to confirm the value is non-null, and throws
HIVE_INVALID_METADATA
in case it is corrupted instead of NPE, to give a more clear error message and provide more information on which partition's metadata is corrupted.Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: