Avoid extra TrinoInputFile#lastModified calls in hive filesystem cache #23327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
iceberg
raunaqmorarka
force-pushed
the
hive-cache-key
branch
from
2a21368 to
77d7d82
Compare
|
Typo in the first commit title |
wendigo
reviewed
Sep 7, 2024
plugin/trino-hive/src/main/java/io/trino/plugin/hive/cache/HiveCacheKeyProvider.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
hive-cache-key
branch
from
77d7d82 to
64de4f6
Compare
Praveen2112
reviewed
Sep 7, 2024
plugin/trino-hive/src/main/java/io/trino/plugin/hive/cache/HiveCacheKeyProvider.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/cache/HiveCacheKeyProvider.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/cache/HiveCacheKeyProvider.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
hive-cache-key
branch
2 times, most recently
from
9312459 to
6f77c25
Compare
|
/test-with-secrets sha=6f77c254df428a126486fdf73b928b83759597b9 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/10768734494 |
Praveen2112
approved these changes
Sep 10, 2024
wendigo
reviewed
Sep 10, 2024
| @@ -112,11 +108,6 @@ public void testCacheFileOperations() | |||
| .add(new CacheOperation("Alluxio.writeCache", "key=p3/")) | |||
| .add(new CacheOperation("Alluxio.writeCache", "key=p4/")) | |||
| .add(new CacheOperation("Alluxio.writeCache", "key=p5/")) | |||
| .add(new CacheOperation("InputFile.lastModified", "key=p1/")) | |||
wendigo
approved these changes
Sep 10, 2024
|
LGTM but I'd like @electrum to chime in in regard to the new API |
|
@raunaqmorarka can you rebase? My changes conflicted with yours |
raunaqmorarka
force-pushed
the
hive-cache-key
branch
from
6f77c25 to
d96dfb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid extra TrinoInputFile#lastModified calls in hive filesystem cache
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: