Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shallow clone documentation #23286

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Joelg96
Copy link
Contributor

@Joelg96 Joelg96 commented Sep 4, 2024

Description

  • Added documentation for support of shallow cloned tables - Delta Lake.
  • Edited the link on the 444 Release note.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@Joelg96
Copy link
Contributor Author

Joelg96 commented Sep 4, 2024

@findinpath Is this example sufficient or do you have a better one?

@Joelg96 Joelg96 force-pushed the jg/add-shallow-clone=docs branch from d26f2ac to 03f17b0 Compare September 4, 2024 15:12
docs/src/main/sphinx/connector/delta-lake.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.md Outdated Show resolved Hide resolved
@mosabua
Copy link
Member

mosabua commented Sep 4, 2024

The other thing I am not sure about is where to put that paragraph ... Currently its in "SQL support - Schema and table management" .. but I feel like this is kinda wrong .. since its NOT about management .. since only read operations are supported. So we can either leave it there .. or put it as top level in "SQL support" or even think of another place .. wdyt @findinpath and @jhlodin ?

@Joelg96 Joelg96 force-pushed the jg/add-shallow-clone=docs branch from 03f17b0 to f32bbb6 Compare September 4, 2024 15:53
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I am good with this now. Any concerns before I merge @findinpath and @jhlodin ?

@Joelg96 Joelg96 requested a review from findinpath September 4, 2024 16:10
@Joelg96
Copy link
Contributor Author

Joelg96 commented Sep 4, 2024

Thank you for the help Manfred.

@Joelg96 Joelg96 force-pushed the jg/add-shallow-clone=docs branch from f32bbb6 to 3117b70 Compare September 5, 2024 19:57
@mosabua
Copy link
Member

mosabua commented Sep 5, 2024

Commit message should maybe be

"Add docs for Delta Lake shallow cloned tables"

@Joelg96 Joelg96 force-pushed the jg/add-shallow-clone=docs branch from 3117b70 to c7aedb5 Compare September 6, 2024 12:52
@Joelg96 Joelg96 requested a review from findinpath September 9, 2024 12:10
@mosabua mosabua merged commit 522de9f into trinodb:master Sep 9, 2024
6 checks passed
@github-actions github-actions bot added this to the 458 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants