Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table handle to ProjectFunctionRewriter.rewrite #23203

Merged
merged 1 commit into from
Sep 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import io.trino.plugin.base.projection.ProjectFunctionRule.RewriteContext;
import io.trino.spi.connector.ColumnHandle;
import io.trino.spi.connector.ConnectorSession;
import io.trino.spi.connector.ConnectorTableHandle;
import io.trino.spi.expression.ConnectorExpression;

import java.util.Iterator;
Expand All @@ -39,8 +40,9 @@ public ProjectFunctionRewriter(ConnectorExpressionRewriter<ExpressionResult> con
this.rules = ImmutableSet.copyOf(requireNonNull(rules, "rules is null"));
}

public Optional<ProjectionResult> rewrite(ConnectorSession session, ConnectorExpression projectionExpression, Map<String, ColumnHandle> assignments)
public Optional<ProjectionResult> rewrite(ConnectorSession session, ConnectorTableHandle handle, ConnectorExpression projectionExpression, Map<String, ColumnHandle> assignments)
{
requireNonNull(handle, "handle is null");
requireNonNull(projectionExpression, "projectionExpression is null");
requireNonNull(assignments, "assignments is null");

Expand Down Expand Up @@ -70,7 +72,7 @@ public Optional<ExpressionResult> rewriteExpression(ConnectorExpression expressi
Iterator<Match> matches = rule.getPattern().match(projectionExpression, context).iterator();
while (matches.hasNext()) {
Match match = matches.next();
Optional<ProjectionResult> rewritten = rule.rewrite(projectionExpression, match.captures(), context);
Optional<ProjectionResult> rewritten = rule.rewrite(handle, projectionExpression, match.captures(), context);
if (rewritten.isPresent()) {
return rewritten;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import io.trino.matching.Pattern;
import io.trino.spi.connector.ColumnHandle;
import io.trino.spi.connector.ConnectorSession;
import io.trino.spi.connector.ConnectorTableHandle;
import io.trino.spi.expression.ConnectorExpression;

import java.util.Map;
Expand All @@ -34,7 +35,7 @@ default boolean isEnabled(ConnectorSession session)
return true;
}

Optional<ProjectionResult> rewrite(ConnectorExpression projectionExpression, Captures captures, RewriteContext<ExpressionResult> context);
Optional<ProjectionResult> rewrite(ConnectorTableHandle handle, ConnectorExpression projectionExpression, Captures captures, RewriteContext<ExpressionResult> context);

interface RewriteContext<ExpressionResult>
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,9 @@ public Optional<ParameterizedExpression> convertPredicate(ConnectorSession sessi
}

@Override
public Optional<JdbcExpression> convertProjection(ConnectorSession session, ConnectorExpression expression, Map<String, ColumnHandle> assignments)
public Optional<JdbcExpression> convertProjection(ConnectorSession session, JdbcTableHandle handle, ConnectorExpression expression, Map<String, ColumnHandle> assignments)
{
return delegate.convertProjection(session, expression, assignments);
return delegate.convertProjection(session, handle, expression, assignments);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ private Optional<ProjectionApplicationResult<ConnectorTableHandle>> applyProject
Set<ConnectorExpression> translatedExpressions = new HashSet<>();

for (ConnectorExpression projection : ImmutableSet.copyOf(projections)) {
RewrittenExpression rewrittenExpression = rewriteExpression(session, nextSyntheticColumnId, projection, assignments, translatedExpressions);
RewrittenExpression rewrittenExpression = rewriteExpression(session, handle, nextSyntheticColumnId, projection, assignments, translatedExpressions);
nextSyntheticColumnId = rewrittenExpression.nextSyntheticColumnId();
newVariablesBuilder.putAll(rewrittenExpression.syntheticVariables());
columnExpressionsBuilder.putAll(rewrittenExpression.columnExpressions());
Expand Down Expand Up @@ -430,6 +430,7 @@ private Optional<ProjectionApplicationResult<ConnectorTableHandle>> applyProject

private RewrittenExpression rewriteExpression(
ConnectorSession session,
JdbcTableHandle handle,
int nextSyntheticColumnId,
ConnectorExpression projection,
Map<String, ColumnHandle> assignments,
Expand All @@ -453,7 +454,7 @@ private RewrittenExpression rewriteExpression(
ImmutableSet.of((JdbcColumnHandle) assignments.get(variable.getName())),
ImmutableList.of(new Assignment(variable.getName(), assignments.get(variable.getName()), variable.getType())));
}
Optional<JdbcExpression> convertedExpression = jdbcClient.convertProjection(session, projection, assignments);
Optional<JdbcExpression> convertedExpression = jdbcClient.convertProjection(session, handle, projection, assignments);
if (convertedExpression.isPresent()) {
String columnName = SYNTHETIC_COLUMN_NAME_PREFIX + nextSyntheticColumnId;
JdbcColumnHandle newColumn = JdbcColumnHandle.builder()
Expand Down Expand Up @@ -481,6 +482,7 @@ private RewrittenExpression rewriteExpression(
for (ConnectorExpression child : projection.getChildren()) {
RewrittenExpression rewrittenExpression = rewriteExpression(
session,
handle,
nextSyntheticColumnId,
child,
assignments,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,9 @@ public Optional<ParameterizedExpression> convertPredicate(ConnectorSession sessi
}

@Override
public Optional<JdbcExpression> convertProjection(ConnectorSession session, ConnectorExpression expression, Map<String, ColumnHandle> assignments)
public Optional<JdbcExpression> convertProjection(ConnectorSession session, JdbcTableHandle handle, ConnectorExpression expression, Map<String, ColumnHandle> assignments)
{
return delegate().convertProjection(session, expression, assignments);
return delegate().convertProjection(session, handle, expression, assignments);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ default Optional<ParameterizedExpression> convertPredicate(ConnectorSession sess
return Optional.empty();
}

default Optional<JdbcExpression> convertProjection(ConnectorSession session, ConnectorExpression expression, Map<String, ColumnHandle> assignments)
default Optional<JdbcExpression> convertProjection(ConnectorSession session, JdbcTableHandle handle, ConnectorExpression expression, Map<String, ColumnHandle> assignments)
{
return Optional.empty();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,9 @@ public Optional<ParameterizedExpression> convertPredicate(ConnectorSession sessi
}

@Override
public Optional<JdbcExpression> convertProjection(ConnectorSession session, ConnectorExpression expression, Map<String, ColumnHandle> assignments)
public Optional<JdbcExpression> convertProjection(ConnectorSession session, JdbcTableHandle handle, ConnectorExpression expression, Map<String, ColumnHandle> assignments)
{
return stats.getConvertProjection().wrap(() -> delegate().convertProjection(session, expression, assignments));
return stats.getConvertProjection().wrap(() -> delegate().convertProjection(session, handle, expression, assignments));
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -840,9 +840,9 @@ public Optional<ParameterizedExpression> convertPredicate(ConnectorSession sessi
}

@Override
public Optional<JdbcExpression> convertProjection(ConnectorSession session, ConnectorExpression expression, Map<String, ColumnHandle> assignments)
public Optional<JdbcExpression> convertProjection(ConnectorSession session, JdbcTableHandle handle, ConnectorExpression expression, Map<String, ColumnHandle> assignments)
{
return projectFunctionRewriter.rewrite(session, expression, assignments);
return projectFunctionRewriter.rewrite(session, handle, expression, assignments);
}

private static Optional<JdbcTypeHandle> toTypeHandle(DecimalType decimalType)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import io.trino.plugin.jdbc.JdbcTypeHandle;
import io.trino.plugin.jdbc.QueryParameter;
import io.trino.plugin.jdbc.expression.ParameterizedExpression;
import io.trino.spi.connector.ConnectorTableHandle;
import io.trino.spi.expression.Call;
import io.trino.spi.expression.ConnectorExpression;
import io.trino.spi.expression.FunctionName;
Expand Down Expand Up @@ -60,7 +61,7 @@ public Pattern<? extends ConnectorExpression> getPattern()
}

@Override
public Optional<JdbcExpression> rewrite(ConnectorExpression projectionExpression, Captures captures, RewriteContext<ParameterizedExpression> context)
public Optional<JdbcExpression> rewrite(ConnectorTableHandle handle, ConnectorExpression projectionExpression, Captures captures, RewriteContext<ParameterizedExpression> context)
{
ConnectorExpression call = captures.get(CALL);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import io.trino.plugin.jdbc.JdbcExpression;
import io.trino.plugin.jdbc.JdbcTypeHandle;
import io.trino.plugin.jdbc.expression.ParameterizedExpression;
import io.trino.spi.connector.ConnectorTableHandle;
import io.trino.spi.expression.Call;
import io.trino.spi.expression.ConnectorExpression;
import io.trino.spi.expression.FunctionName;
Expand Down Expand Up @@ -57,7 +58,7 @@ public Pattern<? extends ConnectorExpression> getPattern()
}

@Override
public Optional<JdbcExpression> rewrite(ConnectorExpression projectionExpression, Captures captures, RewriteContext<ParameterizedExpression> context)
public Optional<JdbcExpression> rewrite(ConnectorTableHandle handle, ConnectorExpression projectionExpression, Captures captures, RewriteContext<ParameterizedExpression> context)
{
Variable argument = captures.get(ARGUMENT);
JdbcTypeHandle typeHandle = ((JdbcColumnHandle) context.getAssignment(argument.getName())).getJdbcTypeHandle();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import io.trino.plugin.jdbc.QueryParameter;
import io.trino.plugin.jdbc.expression.ParameterizedExpression;
import io.trino.spi.block.Block;
import io.trino.spi.connector.ConnectorTableHandle;
import io.trino.spi.expression.Call;
import io.trino.spi.expression.ConnectorExpression;
import io.trino.spi.expression.Constant;
Expand Down Expand Up @@ -76,7 +77,7 @@ public Pattern<? extends ConnectorExpression> getPattern()
}

@Override
public Optional<JdbcExpression> rewrite(ConnectorExpression projectionExpression, Captures captures, RewriteContext<ParameterizedExpression> context)
public Optional<JdbcExpression> rewrite(ConnectorTableHandle handle, ConnectorExpression projectionExpression, Captures captures, RewriteContext<ParameterizedExpression> context)
{
Optional<ParameterizedExpression> leftExpression = rewrite(captures.get(LEFT_ARGUMENT), context);
if (leftExpression.isEmpty()) {
Expand Down