Add support for dropping columns in Memory #22657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
SemionPar
approved these changes
Jul 15, 2024
plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemoryMetadata.java
Outdated
Show resolved
Hide resolved
| @@ -117,7 +117,10 @@ public synchronized List<Page> getPages( | |||
| done = true; | |||
| } | |||
| // Append missing columns with null values. This situation happens when a new column is added without additional insert. | |||
| for (int j = page.getChannelCount(); j < columnIndexes.length; j++) { | |||
| for (int j = 0; j < columnIndexes.length; j++) { | |||
| if (columnIndexes[j] < page.getChannelCount()) { | |||
There was a problem hiding this comment.
Is this related to dropping columns, or a bug fix? Should this be in a separate commit?
| } | ||
|
|
||
| @Override | ||
| public synchronized ColumnMetadata getColumnMetadata(ConnectorSession session, ConnectorTableHandle tableHandle, ColumnHandle columnHandle) | ||
| { | ||
| MemoryTableHandle handle = (MemoryTableHandle) tableHandle; |
There was a problem hiding this comment.
Why this is change necessary?
| @@ -16,7 +16,7 @@ | |||
| import io.trino.spi.connector.ColumnHandle; | |||
| import io.trino.spi.type.Type; | |||
|
|
|||
| public record MemoryColumnHandle(int columnIndex, Type type) | |||
| public record MemoryColumnHandle(int columnIndex, String name, Type type, boolean nullable) | |||
There was a problem hiding this comment.
Are these changes required for dropping columns?
ebyhr
force-pushed
the
ebi/memory-drop-column
branch
from
8cb6afe to
b77e28a
Compare
ebyhr
added
stale-ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes