Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading from Unity catalog with Iceberg REST #22632

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Jul 9, 2024

Description

This PR supports only read operations because Iceberg REST interface in Unity catalog doesn't support creating tables yet.

Note that Databricks Unity catalog provides HTTP interface, but it doesn’t return Iceberg UniForm tables.

Example catalog config properties:

connector.name=iceberg
iceberg.catalog.type=rest
iceberg.rest-catalog.uri=https://dbc-12345678-9999.cloud.databricks.com/api/2.1/unity-catalog/iceberg
iceberg.security=read_only
iceberg.rest-catalog.security=OAUTH2
iceberg.rest-catalog.oauth2.token=***
iceberg.rest-catalog.parent-namespace=test_namespace

Fixes #22609

Release notes

# Iceberg
* Add support for reading from Unity catalog with REST catalog. ({issue}`22609`)

@cla-bot cla-bot bot added the cla-signed label Jul 9, 2024
@github-actions github-actions bot added docs iceberg Iceberg connector labels Jul 9, 2024
@ebyhr ebyhr force-pushed the ebi/iceberg-rest-unity-catalog branch 2 times, most recently from 2264135 to 0fab311 Compare July 12, 2024 08:19
@ebyhr ebyhr force-pushed the ebi/iceberg-rest-unity-catalog branch from 0fab311 to b921d5e Compare July 16, 2024 13:17
@ebyhr ebyhr force-pushed the ebi/iceberg-rest-unity-catalog branch 2 times, most recently from 5fa5d2d to fc443b3 Compare July 25, 2024 02:17
@decgowran
Copy link

@ebyhr do you know if this WIP or planning to be merged in the near future ?

@ebyhr ebyhr force-pushed the ebi/iceberg-rest-unity-catalog branch from fc443b3 to ed7d20b Compare September 17, 2024 00:22
@ebyhr ebyhr force-pushed the ebi/iceberg-rest-unity-catalog branch 2 times, most recently from 2bfbb69 to d20bb4e Compare September 24, 2024 04:46
@mayankvadariya mayankvadariya self-requested a review September 24, 2024 14:27
@MichaelKoch
Copy link

any roadmap to merge that PR ?

@decgowran
Copy link

any roadmap to merge that PR ?

@MichaelKoch Im looking into alternative in k8s with https://github.com/duckdb/uc_catalog

@MichaelKoch
Copy link

@decgowran : thanks for the link ..
i would love to see that this PR get merged to use trino + uc
IMHO : a great partnership

@ebyhr ebyhr force-pushed the ebi/iceberg-rest-unity-catalog branch 2 times, most recently from e99ee8d to ea71d99 Compare October 11, 2024 08:15
@ebyhr ebyhr marked this pull request as ready for review October 11, 2024 08:27
@ebyhr ebyhr requested review from anusudarsan and wendigo October 11, 2024 11:19
@ebyhr ebyhr force-pushed the ebi/iceberg-rest-unity-catalog branch 3 times, most recently from 5961a90 to b0ba93f Compare October 15, 2024 04:02
@ebyhr ebyhr force-pushed the ebi/iceberg-rest-unity-catalog branch from b0ba93f to aab95ec Compare October 15, 2024 06:10
@ebyhr ebyhr requested a review from raunaqmorarka October 15, 2024 06:58
@ebyhr ebyhr merged commit 3c20a5c into master Oct 15, 2024
47 checks passed
@ebyhr ebyhr deleted the ebi/iceberg-rest-unity-catalog branch October 15, 2024 09:15
@github-actions github-actions bot added this to the 462 milestone Oct 15, 2024
@decgowran
Copy link

Hi @ebyhr Will this be available in the next Trino Release to test ?

@@ -497,6 +500,19 @@ iceberg.catalog.type=rest
iceberg.rest-catalog.uri=http://iceberg-with-rest:8181
```

`iceberg.security` must be `read_only` when connecting to Databricks Unity catalog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when a user forgets ot set iceberg.security=read_only ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write operations will result in the following error:

Query 20241015_222748_00008_srrgj failed: Unable to process: Status: 405
Description: Method Not Allowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Add support for Unity catalog in Iceberg connector
6 participants