-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aircompressor to 3.0 #22532
Update aircompressor to 3.0 #22532
Conversation
d216566
to
4c77115
Compare
Started benchmark workflow for this PR with test type =
|
Started benchmark workflow for this PR with test type =
|
057b5e9
to
83598e9
Compare
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
83598e9
to
b4ce9a2
Compare
30849fc
to
512ed7b
Compare
512ed7b
to
f989c5b
Compare
core/trino-main/src/main/java/io/trino/execution/buffer/PageDeserializer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/buffer/PageSerializer.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/protocol/PreparedStatementEncoder.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/airlift/compress/Compressor.java
Outdated
Show resolved
Hide resolved
f989c5b
to
a290c80
Compare
a290c80
to
020ff76
Compare
Updated to released version of aircompressor |
Started benchmark workflow for this PR with test type =
|
@wendigo does it use native decompressors? Could you share the numbers for both Intel and ARM? |
@sopel39 you mean micro (JMH) or macro benchmarks (benchto)? |
Some JMH results were posted in the aircompressor PR:
|
Are these JMH results for ARM or Intel? We should test both TBH in case there is regression in one arch.
Bechto TPC-DS would be awesome! Arm/Intel |
@sopel39 this is ARM, I'm not sure whether we ran these for Intel but I don't expect regression there as well |
@sopel39 last time I've ran benchto benchmarks on Iceberg/SF1000 it showed ~10% performance improvement on read and ~10% on write. |
23d5efe
to
b7da15d
Compare
Started benchmark workflow for this PR with test type =
|
5729bf5
to
f0433df
Compare
f0433df
to
a73459f
Compare
@dain I've updated this PR to use v3. Please review |
a73459f
to
2f636c0
Compare
core/trino-main/src/main/java/io/trino/execution/buffer/PageDeserializer.java
Outdated
Show resolved
Hide resolved
2f636c0
to
d81c541
Compare
core/trino-main/src/main/java/io/trino/execution/buffer/CompressionCodec.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/buffer/CompressionCodec.java
Outdated
Show resolved
Hide resolved
d81c541
to
2d799f9
Compare
2d799f9
to
af57a5f
Compare
Updates aircompressor to 3.0.
Changes include: