Allow pinning Glue credentials provider to StsWebIdentityTokenFileCredentialsProvider #22425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
The CI failure seem unrelated to this change, I see similar failures on master. Please let me know if I need to do anything to resolve it. |
|
/test-with-secrets sha=6a006276b0810c087fdde5885d5825a20c42bbb6 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/9577963913 |
There was a problem hiding this comment.
@rohanag12 how did you test this? Are there any docs around Glue that would need to be updated to mention this new property?
Apologies for delayed response, I finally got time to work on this again. I tested this by doing the following:
In the logs, I can see the following stack trace when the first query is executed and the glue client is initialized (click to expand):The stack trace indicates that the glue client is directly using the |
rohanag12
force-pushed
the
hive-glue-metastore-web-identity-token-auth
branch
from
6a00627 to
a48d6f3
Compare
nineinchnick
approved these changes
Jul 15, 2024
rohanag12
force-pushed
the
hive-glue-metastore-web-identity-token-auth
branch
from
a48d6f3 to
956c8a4
Compare
Updated docs. |
|
@findepi could you please take a look and review/merge when you get a chance? |
|
@ebyhr can you run tests with secrets? |
|
/test-with-secrets sha=956c8a4ae8cb5c6f6f0ed962094e42fe3bc34cff |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/9952007596 |
findepi
approved these changes
Jul 16, 2024
|
Is there something I need to do to fix the test failure? I don't really understand why it's failing. |
|
It might be an intermittent failure. Maybe someone with write access could retry that single job. |
|
@ebyhr can you please trigger test with secrets again (or merge if it looks good 😄) |
ebyhr
approved these changes
Jul 17, 2024
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueMetastoreModule.java
Outdated
Show resolved
Hide resolved
…dentialsProvider Allow users to only use the StsWebIdentityTokenFileCredentialsProvider instead of the default credentials provider chain for Glue v2.
rohanag12
force-pushed
the
hive-glue-metastore-web-identity-token-auth
branch
from
956c8a4 to
4c72db1
Compare
|
Hi ALL. The option is only for Hive Connector? Can't set releated discussion on slack: https://trinodb.slack.com/archives/CGB0QHWSW/p1724690300929519 |
|
For someone who want to set Glue's AWS WebIdentity Credential for Hive, Iceberg Connectors Glue (Recent) Module Config Glue V1 (Legacy) Module Config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to only use the StsWebIdentityTokenFileCredentialsProvider instead of the default credentials provider chain for Glue v2.
The Glue v1 implementation supported specifying a custom credential provider, but that ability was removed in the Glue v2 implementation. This commit provides similar functionality to the flags added for S3 in #22162 and #22163.
Additional context and related issues
Ref #20657 (comment).
Fixes #15267
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: