Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check duplicated field names in Iceberg #22409

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Jun 18, 2024

Description

We should fix Delta Lake connector as a follow-up.
Fixes #16273

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jun 18, 2024
@github-actions github-actions bot added the iceberg Iceberg connector label Jun 18, 2024
@ebyhr ebyhr force-pushed the ebi/iceberg-row-field-names branch 2 times, most recently from a7de18c to 81e2dec Compare June 18, 2024 04:34
@@ -6595,6 +6595,41 @@ public void testDeleteRetainsMetadataFile()
assertUpdate("DROP TABLE " + tableName);
}

@Test
@Override // Override because ambiguous field name is disallowed in the connector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ thank you for this comment

@ebyhr ebyhr force-pushed the ebi/iceberg-row-field-names branch from 81e2dec to f4f8c9d Compare June 18, 2024 10:44
@ebyhr ebyhr force-pushed the ebi/iceberg-row-field-names branch from f4f8c9d to de69319 Compare June 19, 2024 01:09
@ebyhr ebyhr force-pushed the ebi/iceberg-row-field-names branch from de69319 to e9609fd Compare June 19, 2024 01:15
@ebyhr ebyhr merged commit 3fd8b81 into trinodb:master Jun 19, 2024
42 of 43 checks passed
@ebyhr ebyhr deleted the ebi/iceberg-row-field-names branch June 19, 2024 02:01
@github-actions github-actions bot added this to the 450 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

Iceberg connector can create tables having difference case fields in row types, but can't read it
3 participants